-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: link go.mod's to tagged errors/v1.0.0-beta.2 go.mod #10878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
should we do a breakout discussion in discord on smaller packages vs a std package?
sure, want to kick that off? |
Seems like #10879 needs to be merged first. |
Okay, I think that's fixed now |
Codecov Report
@@ Coverage Diff @@
## master #10878 +/- ##
==========================================
+ Coverage 64.65% 64.88% +0.22%
==========================================
Files 614 632 +18
Lines 58984 59901 +917
==========================================
+ Hits 38139 38867 +728
- Misses 18704 18835 +131
- Partials 2141 2199 +58
|
This links all of the other go.mod's in the SDK that need it to
github.com/cosmos/cosmos-sdk/errors v1.0.0-beta.2
and also removes the dependency of the ORM on the SDK itself. Follow up to #10779.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change